Question

I’ve just found in my java project this code snippet:

List<IssueType> selectedIssueTypes = new ArrayList<IssueType>();  
    for (Object item : selectedItems) 
        selectedIssueTypes.add((IssueType) item);

How do you think, can this style be used?

Answer 1

Imho, this style seems to show a hierarchy that isn’t there. Also I would advocate to always use braces and I like to separate declarations and code with an empty line, so I would use:

List<IssueType> selectedIssueTypes = new ArrayList<IssueType>();  

for (Object item : selectedItems) {
    selectedIssueTypes.add((IssueType) item);
}