Question

I’ve mostly only used coldfusion for queries before never needed structs or any object notation until now. The server I am working on doesn’t have debugging turned on just a “500- internal server error.” so I am unable to see why my code is not working and sadly I do not have the ability to turn debugging on.

By trial and error with commenting blocks out I’ve noticed the errors are occurring in my struct line, and adding the struct to my array. From what I’ve read of the CF documentation I do not see any syntax errors but any help would be much appreciated as to if I have any bad logic or what could be wrong.

 <cfset dataArray = []>
 <cfset i = 0>
 <cfloop query="getMembers">
        <cfquery name="getmaps" datasource=“a" dbtype="odbc">
        SELECT       member_id, mlong, mlat
        FROM         maps 
        WHERE       member_id = '#getMembers.MemberID#'
        </cfquery>
        <cfif getmaps.recordcount eq 1>
            <!--- temp structure to insert into array --->
            <cfset dataTemp = {
                memberID = getMemebers.memberID, 
                name = getMemebers.MemberName, 
                long = getmaps.mlong, 
                lat = getmaps.mlat 
            }>
            <cfset dataArray[i] = dataTemp>
            <cfset i++>
        </cfif>
    </cfloop>

Answer 1

I addition to Shawn’s comment, I believe you’ll have a problem with starting your array index at 0, rather than 1. Coldfusion begins array indices at 1.

edit Some more suggestions:

<cfset dataArray = []>
 <cfloop query="getMembers">
        <!--- Not usually a good idea to query each time through a loop - should be able to do a single query outside it --->
        <cfquery name="getmaps" datasource=“a" dbtype="odbc">
        SELECT       member_id, mlong, mlat
        FROM         maps 
        WHERE       member_id = <cfqueryparam value='#getMembers.MemberID#' cfsqltype="cf_sql_varchar"><!--- assuming varchar since you had quotes around it --->
        </cfquery>
        <cfif getmaps.recordcount eq 1>
            <!--- temp structure to insert into array --->
            <cfset dataTemp = {
                memberID = getMembers.memberID, 
                name = getMembers.MemberName, 
                long = getmaps.mlong, 
                lat = getmaps.mlat 
            }>
            <cfset ArrayAppend(dataArray,dataTemp)>
        </cfif>
</cfloop>