Question

I’ve seen many different examples of using HttpURLConnection + InputStream, and closing them (or not closing them) after use. This is what I came up with to make sure everything is closed after finished, whether there’s an error or not. Is this valid?:

HttpURLConnection conn = null;
InputStream is = null;
try {
    URL url = new URL("http://example.com");

    // (set connection and read timeouts on the connection)
    conn = (HttpURLConnection)url.openConnection();

    is = new BufferedInputStream(conn.getInputStream());

    doSomethingWithInputStream(is);

} catch (Exception ex) {
} finally {
    if (is != null) {
        try {
            is.close();
        } catch (IOException e) {
        }
    }
    if (conn != null) {
        conn.disconnect();
    }
}

Thanks

Answer 1

Yep.. Doing the end part in finally would be best idea because if code fails somewhere, program won’t reach till .close(), .disconnect() statements that we keep before catch statements…

If the code fails somewhere and exception is thrown in between of the program, still finally get executed regardless of exception thrown…