Question

Just trying to figure out an easy way to either pass or share some data between the main window and a dialog box.

I’ve got a collection of variables in my main window that I want to pass to a dialog box so that they can be edited.

The way I’ve done it now, is I pass in the list to the constructor of the dialog box:

private void Button_Click(object sender, RoutedEventArgs e)
{
    var window = new VariablesWindow(_templateVariables);
    window.Owner = this;
    window.ShowDialog();
    if(window.DialogResult == true) 
        _templateVariables = new List<Variable>(window.Variables);
}

And then in there, I guess I need to deep-copy the list,

public partial class VariablesWindow : Window
{
    public ObservableCollection<Variable> Variables { get; set; }

    public VariablesWindow(IEnumerable<Variable> vars)
    {
        Variables = new ObservableCollection<Variable>(vars);
        // ...

So that when they’re edited, it doesn’t get reflected back in the main window until the user actually hits “Save”.

Is that the correct approach? If so, is there an easy way to deep-copy an ObservableCollection? Because as it stands now, I think my Variables are being modified because it’s only doing a shallow-copy.

Answer 1

I think you are indeed following the right approach here, but you need to make a deep copy of your ObservableCollection. To do so, make sure that your class ‘Variable’ is Clonable (try to implement ICloneable)

foreach(var item in vars)
{
    Variables.Add((Variable)item.Clone());
}