Question

Let’s assume you have a very well designed Delphi project, which respects the dependency injection and some other good practices.

Now let’s assume you need to mock a class defined as:

TMyClass = class
public
  procedure Method1;
  procedure Method2
end;  

Method1 and Method2 are not virtual. What do you do in this case? To mock an object we need to inherit it and override every method you want to mock, but it is not possible in this case because they are not virtual. Should I change the source code to add virtual on every method I need to mock? Is not it bad?

Edit

I was thinking about creating a compiler directive to make all fields in the class to be virtual, is it a good ideia? Only my test suite is going to set the compiler directive.

EDIT2*

Embarcadero should provide an easy way of changing a method pointer of a class to another method point, without the need for virtual.

Answer 1

Make the methods virtual so you can mock them. (They don’t need to be abstract.)

If you cannot do that, then wrap the class with another class. Make the wrapper’s methods virtual, and in the default implementation, just forward call calls to the original class. Wherever your program uses the original class, replace it with the wrapper. Now, mock the wrapper.