Question

Let’s say I have a class FOO.

I want to have a std::vector of FOO.

Is it better if I do something like this:

FOO foo;
foo.init();
foo.prop = 1;
std::vector<FOO> myvec;

myvec.push_back(foo);
foo.prop = 2;
myvect.push_back(foo);

or is it better practice to do:

std::vector<FOO> myvec;
FOO foo;
myvec.push_back(foo);
myvec.back().init();
myvec.back().prop = 1;

myvec.push_back(foo);
myvec.back().init();
myvec.back().prop = 2;

I’m basically not sure if its better to make a model and push in the model instead of making an instance, pushing it, then modifying it from the vector. Also, which one is safer and least likely to result in memory leaks?

Thanks

Answer 1

Neither method has any memory issues as you’re dealing with values and aren’t dynamically allocating any objects manually.

I would favour giving FOO a constructor which does whatever init does and sets prop to the appropriate value. Then you can just push the values you want:

myvec.push_back(FOO(1));
myvec.push_back(FOO(2));