Question

Maybe I’m going completely off track with what I’m trying to do, but I’m tempted just to go back to version 2 because I got that working easily (but I would like to be mobile-friendly).

I’m trying to generate a few markers, and to save code, I’ve put the marker generation into a for loop, which loops through an array of markers (there are actual values instead of (long,lat,x,x,x) in the real array).

Is something just going completely over my head?

 function initialize() {
    var latlng = new google.maps.LatLng(25, 15);
    var myOptions = {
      zoom: 2,
      center: latlng,
      mapTypeId: google.maps.MapTypeId.ROADMAP
    };
    var map = new google.maps.Map(document.getElementById("map_canvas"), myOptions);


var myMarker = new Array();
myMarker[0] = new Array(long,lat,x,x,x); 
myMarker[0] = new Array(long,lat,x,x,x); 
myMarker[0] = new Array(long,lat,x,x,x); 
myMarker[0] = new Array(long,lat,x,x,x); 
myMarker[0] = new Array(long,lat,x,x,x); 
myMarker[0] = new Array(long,lat,x,x,x); 
myMarker[0] = new Array(long,lat,x,x,x); 

for(var i = 0; i < myMarker.length; i++) {
    var marker = new google.maps.Marker({
        position: new google.maps.LatLng(myMarker[i](1), myMarker[i](2)), 
        map: map, 
        title: myMarker[i](5)
      });
    var infowindow = new google.maps.InfoWindow({content: myMarker[i](5)}); 
    google.maps.event.addListener(marker, 'click', function() {
        infowindow.open(map,marker);
    });
}

}

This code works when I make the markers individually.

Answer 1

The problem is that all those listener functions are sharing the same “map” and “marker” values. You need to wrap them up in another function:

(function(map, marker) {
  google.maps.event.addListener(marker, 'click', function() {
    infowindow.open(map,marker);
  });
})(map, marker);

The “map” and “marker” variables change on each iteration through the loop. Those listener functions don’t have a copy of them unless you explicitly set something up to do that, like I did in that example. Thus, all the listeners end up working on the last thing the loop touched!

edit — actually now that I read over the code again, “map” looks like it’s not changing, so it can probably be taken out of my setup (doesn’t hurt anything though).