Question

My code needs to capture the ‘src’ of an image in a variable. It then needs to insert this variable into a ‘href’ tag on a link which surrounds the image.

$('.fancybox-image-li img').each(function(test) {
    var test = $(this).attr("src");
    $('.fancybox-image-link').attr('href', ''+test+'');
});

Unfortunately what seems to be happening is the ‘test’ var is only getting the attribute of the last img and then inserting this into all the ‘href’ attributes.

Any ideas how I can get the variable to change per image.

Answer 1

Maybe you should do

$('.fancybox-image-li img').each(function(test) {

    var test = $(this).attr("src");
    // find the closest element with the class
    $( this ).closest('.fancybox-image-link').attr('href', ''+test+'');

});

Otherwise in each iteration you set the href of all $('.fancybox-image-link') to the current href attribute, thus getting alle the $('.fancybox-image-link') with the last href