Question

My compiler’s complaining and throwing up an error (see the title) about this code:

int toLevel(int xp)
{
    int points = 0;
    int level = 1;
    for(; level < MAX_LEVEL; level++)
    {
        points += floor(level + 300*pow(2, level/7.));
        if(xp < points)
        {
            break;
        }
    }
    return level;
}

The error is on the for(; level < MAX_LEVEL; level++) line, and the full error log looks like (that’s line 50, for reference):

In function 'int toLevel(int)':
50    error: expected primary-expression before ';' token
50    error: expected ')' before ';' token
50    error: expected ';' before ')' token
48    warning: unused variable 'points'
59    error: expected '}' at end of input
59    warning: no return statement in function returning non-void
=== Build finished: 4 errors, 2 warnings ===

Any ideas? I’m assuming I haven’t closed a bracket somewhere, but I just can’t find it.
As I suspect this may be the case, here’s the full code for that file:

#include <iostream>
#include <fstream>
#include <sstream>
#include <vector>
#include <math.h>

using namespace std;

#define MAX_LEVEL 99;

#include "main.h"

int main()
{
    Player player;
    loadSkills(player);
    if(!loadGame(player))
    {
        cout << "It looks like its your first time playing." << endl;
        cout << "What's your name?: ";
        cin >> player.name;
    }
    cout << "Hello " << player.name << ", you're level " << toLevel(player.xp) << endl;
    //TODO
    return 0;
}

//Returns true if loaded, false otherwise
bool loadGame(Player player)
{
    //TODO
    return false;
}

void loadSkills(Player player)
{
    vector<Skill> skills;
    skills.push_back((Skill){"Melee"});
    skills.push_back((Skill){"Woodcutting"});
    skills.push_back((Skill){"Firemaking"});
    skills.push_back((Skill){"Fishing"});
    skills.push_back((Skill){"Cooking"});
    player.skills = skills;
}

int toLevel(int xp)
{
    int points = 0;
    int level = 1;
    for(; level < MAX_LEVEL; level++)
    {
        points += floor(level + 300*pow(2, level/7.));
        if(xp < points)
        {
            break;
        }
    }
    return level;
}

and the main.h it references:

#ifndef MAIN_H_INCLUDED
#define MAIN_H_INCLUDED

vector<string> &split(const string &s, char delim, vector<string> &elems) {
    stringstream ss(s);
    string item;
    while(getline(ss, item, delim)) {
        elems.push_back(item);
    }
    return elems;
}

//Ease of use method
vector<string> split(const string &s, char delim) {
    vector<string> elems;
    return split(s, delim, elems);
}

struct Skill
{
    string name;    //The name of the skill
};

struct Player
{
    int health;             //The player's current health
    int xp;                 //The player's xp
    int maxhealth;          //The player's max health
    vector<Skill> skills;   //The skills available to the player
    string name;            //The player's name
};

class InteractOption
{
    public:
    void doAction();//What should happen
    bool succeeded; //If true, they get the xp for it.
    int xp;         //Amount of xp gained for doing
    Skill skill;    //Skill to gain xp in
    string name;    //"Chop"/"Attack"/etc
};

class WorldObject
{
    public:
    InteractOption interactOption;  //The option for interacting with the object.
                                    //Can be null (i.e. can't interact)
    string name;                    //"Tree"/"Goblin"/etc
};

bool loadGame(Player);
void loadSkills(Player);
int toLevel(int);

#endif // MAIN_H_INCLUDED

Answer 1

Remove the the trailing semi-colon from the MAX_LEVEL macro:

#define MAX_LEVEL 99;

as when the macro is replaced in the for loop it becomes:

for(; level < 99;; level++)

which is illegal syntax.