Question

My DialogButton is not dismissing even though I have .dismiss() in it. My code:

    @Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.iabout);
    // custom dialog
    final Dialog dialog = new Dialog(context);
    dialog.setContentView(R.layout.iabout);


    dialogButton = (Button) dialog.findViewById(R.id.btAboutOK);
    // if button is clicked, close the custom dialog
    dialogButton.setOnClickListener(new OnClickListener() {
        public void onClick(View v) {
            dialog.dismiss();
        }
    }); 
}

appreciate any help.

Answer 1

Please dont use dialog’s, please use DialogFragments. The are much easier to maintain.
(For pre honeycomb add the support library to your project)

Then in your DialogFragment class use the AlertDialog.Builder in the onCreateDialog(Bdl bundle) like so:

public class MyDialogFragment extends DialogFragment {


@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {

    return new AlertDialog.Builder(getActivity())
            .setIcon(R.drawable.alert_dialog_icon)
            .setTitle(R.string.alert_dialog_custom_title)
            .setPositiveButton(android.R.string.ok,
                new DialogInterface.OnClickListener() {
                    public void onClick(DialogInterface dialog, int whichButton) {
                        ((MyActivity)getActivity()).doPositiveClick();
                    }
                }
            )
            .setNegativeButton(android.R.string.cancel,
                new DialogInterface.OnClickListener() {
                    public void onClick(DialogInterface dialog, int whichButton) {
                        ((MyActivity)getActivity()).doNegativeClick();
                    }
                }
            )
            .create();
}

}

These examples can be found here.

At the very lease if you are going to use the old way of using dialogs please at least use the dialog builder.

Then as per the example above you can set the callback methods.

If you you want to do custom dialogs with custom layouts, the use DialogFragments, then you can control the dialogs lifecycle correctly and then your custom button can just call dismiss() in the DialogFragment.

Read the examples as mentioned here.

Cheers,
Chris