Question

My for loop is too long. As demo there is three for loops going on for methodB. Is there a way I could reduce this to a short for loop (one for loop)? Thanks

    public class MyMates  
    {

       private static TreeSet<String> myTable = new TreeSet<String>();

       private static String[] names1 = null;
       private static String[] names2 = null;
       private static String[] names3 = null;


       public MyMates()
       {
        super();
        myTable = new TreeSet<String>();
       }


       public  static String methodA(String aTemp)
       {
         String[] names1 = new String[] {"Amy", "Jose", "Jeremy", "Alice", "Patrick"};
         String[] names2 = new String[] { "Alan", "Amy", "Jeremy", "Helen", "Alexi"};
         String[] names3 = new String[] { "Adel", "Aaron", "Amy", "James", "Alice" };

         return aTemp;
      } 



    public static String methodB(String bTemp)
     {

        for (int i = 0; i < names1.length; i++) {
        myTable.add(names1[i]);
        }
        System.out.println(myTable);

        for (int i = 0; i < names2.length; i++) {
        myTable.add(names2[i]);
        }
        System.out.println(myTable);

       for (int i = 0; i < names3.length; i++) {
       myTable.add(names3[i]);
       }
       System.out.println(myTable);

    return bTemp;
   }

enter code here

Answer 1

An alternative which uses a 2 dimensional array and two nested loops
(I don’t understand parameter and return values in methods A/B)

public class MyMates {
    private static TreeSet<String> myTable = new TreeSet<String>();
    private static String[][] names;

    public MyMates() {
        super();
        myTable = new TreeSet<String>();
    }

    public static String methodA(String aTemp) {
        names = new String[][] {
                { "Amy", "Jose", "Jeremy", "Alice", "Patrick" },
                { "Alan", "Amy", "Jeremy", "Helen", "Alexi" },
                { "Adel", "Aaron", "Amy", "James", "Alice" } };

        return aTemp;
    }

    public static String methodB(String bTemp) {

        for (int row = 0; row < names.length; row++) {
            for (int i = 0; i < names[row].length; i++) {
                myTable.add(names[row][i]);
                System.out.println(myTable);
            }
        }
        return "";
    }

    public static void main(String[] args) {
        methodA("");
        methodB("");
    }
}