Home/ Questions/Q 855907
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-15T08:09:15+00:00

My job is the maintain one application which heavy use SQL server (MSSQL2005). Until

  • 0

My job is the maintain one application which heavy use SQL server (MSSQL2005).
Until now middle server stores TSQL codes in XML and send dynamic TSQL queries without using stored procs.
As I am able change those XML queries I want to migrate most of my queries to stored procs.
Question is folowing:

Most of my queries have same Where conditions against one table

Sample:

Select 
   .....
from ....
where ....
and (a.vrsta_id = @vrsta_id  or @vrsta_id = 0)
and (a.podvrsta_id = @podvrsta_id or @podvrsta_id = 0)
and (a.podgrupa_2 = @podgrupa2_id or @podgrupa2_id = 0)
and (
 (a.id in (select art_id from osobina_veze where podosobina_id in (select ado from dbo.fn_ado_param_int(@podosobina))
        group by art_id
        having count(art_id)= @podosobina_count ))
     or ('0' = @podosobina)
 )

They also have same where conditions on other table.

How I should organize my code ?
What is proper way ?
Should I
make table valued function that I will use in all queries
or use #Temp tables and simple inner join my query to that each time when proc executing?
or use #temp filed by table valued function ?
or leave all queries with this large where clause and hope that index is going to do their jobs.
or use WITH(statement)

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    i’ve come to realize that having such complex searches in a single query is not really a good idea.

    i prefer to construct the sql depeding on the input condition values.
    this makes it easier fo rsql server to construct a better execution plan for each search.
    this way i’d bet that you have a sub-optimal execution plan for your queries.

    i realize that this would include dynamic sql so the usual warnings for it apply.

    • 0