Question

My question is similar to this question. I’ve used this code to extend ImageView to form TouchImageView. In my onCreate() method, I want to call

setImage(Bitmap bm, int displayWidth, int displayHeight)

but I don’t know the width or height to use. When I call getHeight(), it gives me zero.

I tried to avoid the 0 using kcoppock‘s answer to the previously mentioned question, but was unsuccessful. The onPreDraw() listener is called several times per second and I can’t figure out how to only call it once.

Answer 1

That’s a brittle approach for something like this. Android Views are measured by their parent View using the onMeasure method. By providing an initial size to a setImage method to scale to (and especially if you set it based on the display size) you’re inviting complexity whenever you want to nest this View within others. Larger screen devices like tablets are a good example of this.

A more idiomatic approach would implement the setImage method of TouchImageView without the width/height parameters at all. Instead it would defer setting the scale and matrices until measurement and implement onMeasure something like this:

protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
    super.onMeasure(widthMeasureSpec, heightMeasureSpec);
    if (mNeedsInitialScale) { // Set by setImage when a new image is set
        // The measured width and height were set by super.onMeasure above
        setInitialScale(getMeasuredWidth(), getMeasuredHeight());
        mNeedsInitialScale = false;
    }
}

Where the setInitialScale method does everything that the linked setImage method does after the call to super.setImageBitmap. setImage should also set the mNeedsInitialScale field to true.

This way you will never need to worry about the initial size to use, it will be obtained automatically from the View during normal measurement whenever a new image is set.