Question

My script_a.php:

try {
    Class1::tryThis();
}
catch (Exception $e) {
    // Do stuff here to show the user an error occurred
}

Class1::tryThis() has something like:

public function tryThis() {
    Class2::tryThat();
    self::logSuccessfulEvent();
}

The problem is that Class2::tryThat() can throw an exception.

If it does throw an exception, it seems that the line self::logSuccessfulEvent(); still gets executed.

How can I refactor this code so that self::logSuccessfulEvent() only occurs when an exception is not thrown, yet at the same time letting script_a.php know when an exception has been thrown?

Answer 1

This function will return whether or not the operation was successful (true = success, false = failure)

public function tryThis() {
   $success = true;

   try {
       Class2::tryThat();
       self::logSuccessfulEvent();
   } catch( Exception $e) {
       $success = false;
   }

   return $success;
}