Question

Not confident about whether this will be downvoted or closed… I need expert opinion on this.

The context is in our application, we have written code like :

//countryId is an integer, searchCity() expects two String parameters
loadCity(countryName , countryId + "");

Will it make any difference if I change (I am being forced to do so) the call like :

loadCity(countryName, String.valueOf(countryId));

Or,

loadCity(countryName, Integer.toString(countryId));

Will this make any difference in sense of performance?

Answer 1

For the example you have given, the answer will really depend on the type of ‘integer’ you are using.

loadCity(countryName , countryId + "");

For an Integer object this is equivelent to :

loadCity(countryName, countryId.toString() + "");

Whereas for an int primitive, this code is equivelent to :

loadCity(countryName, String.valueOf(countryId) + "");

In either case, as ArjunShankar pointed out there is a good chance that the compiler has optimised your code anyway. So if your question is ‘do I go back and refactor all my code?’, then I would say ‘don’t sweat the small stuff’. But in the future use a more conventional approach to avoid the down votes.