Question

Ok, I am not sure what is wrong with me, but I am trying to find and replace a portion of multiple URLs.

Basically, I have some URLs that are being dynamically added to my site. All have a class of ‘newsLink’ some of the links are pulling up google.docs viewer and I need to remove that.

Here is my code thus far:

$('a.newsLink').each(function(){
var lnk = $('a.newsLink').attr();
var re = new RegExp("http://docs.google.com/viewer?url=","g");
lnk.replace(re, "");
});

the links look like:

<a href='http://docs.google.com/viewer?url=myHomePage.pdf' class='newsLink' target='_blank'>

I would like to remove the first part so that the link looks like:

<a href='http://myHomePage.pdf' class='newsLink' target='_blank'>

Anyway, no luck this far…can anyone please help.

Answer 1

First, you are getting all links again inside of the loop. Then, you try to get an attribute, but didn’t say which one. Finally, you try to use replace without assigning the return value to anything.

This is what your code should be:

$('a.newsLink').each(function(){
    var lnk = this.href;
    this.href = lnk.replace("http://docs.google.com/viewer?url=", "");
});

Note: I’m assuming you want the links to become e.g. myHomePage.pdf, without the protocol.