Question

ok now i am using the SQL database to get the values from different tables… so i make the connection and get the values like this:

DataTable dt = new DataTable();
SqlConnection connection = new SqlConnection();
connection.ConnectionString = ConfigurationManager.ConnectionStrings["XYZConnectionString"].ConnectionString;
connection.Open();
SqlCommand sqlCmd = new SqlCommand("SELECT * FROM Machines", connection);
SqlDataAdapter sqlDa = new SqlDataAdapter(sqlCmd);

sqlCmd.Parameters.AddWithValue("@node", node);
sqlDa.Fill(dt);
connection.Close();

so this is one query on the page and i am calling many other queries on the page.

So do i need to open and close the connection everytime…???

also if not this portion is common in all:

DataTable dt = new DataTable();
SqlConnection connection = new SqlConnection();
connection.ConnectionString = ConfigurationManager.ConnectionStrings["XYZConnectionString"].ConnectionString;
connection.Open();

can i like put it in one function and call it instead.. the code would look cleaner…
i tried doing that but i get errors like:

Connection does not exist in the current context.

any suggestions???

thanks

Answer 1

1. You can definitely share the “open connection” code, no reason to duplicate it.
2. With the SQL Server provider for ASP.NET, there is very little overhead with “closing” the connection every time. It just returns the connection to your process’ connection pool (see here), so opening the next connection will use very little overhead. I think it is good practice to close the connection after each operation