Question

omg im am so confused right now

what is wrong here and what can i do to fix it

EDIT: omg i am so sorry…i am just so fluctuated right now that i cant even ask a question

i want to assign 10 inputed char strings to a pointer array.

using namespace std;

int main(int argc, char *argv[])
{
    char *mess[10];
    int i = 0;

for (; i < 10; i++)
{                 
    cout << "Enter a string: ";   
    cin.getline(mess[i], 80);
}

for (i = 0; i < 10; i++)
    cout << mess[i];

system("PAUSE");
return EXIT_SUCCESS;
}

Answer 1

What you want is probably declare your array this way:

char mess[10][80];

As you are reading up to 80 characters from getline.

Your current implementation builds an array of 10 char* which are never initialized to point on allocated buffers.

A much safer way would be to use std::string as the buffer size will be handled for you. A simple change to:

#include <iostream>
#include <string>
using namespace std;

int main(int argc, char *argv[])
{
    std::string mess[10];
    int i = 0;

    for (; i < 10; i++)
    {                 
        cout << "Enter a string: ";   
        cin >> mess[i];
    }

    for (i = 0; i < 10; i++)
        cout << mess[i] << endl; // you probably want to add endl here

    system("PAUSE");
    return EXIT_SUCCESS;
}

Should give you what you want.

EDIT

If you absolutely need char * (which is not a good idea), here’s what you’re looking for:

#include <iostream>
using namespace std;

int main(int argc, char *argv[])
{
    char* mess[10];
    int i = 0;

    for (; i < 10; i++)
    {                 
        cout << "Enter a string: ";   
        mess[i] = new char[80]; // allocate the memory
        cin.getline(mess[i], 80);
    }

    for (i = 0; i < 10; i++)
    {
        cout << mess[i] << endl;
        delete[] mess[i]; // deallocate the memory
    }

    // After deleting the memory, you should NOT access the element as they won't be pointing to valid memory

    system("PAUSE");
    return EXIT_SUCCESS;
}