Question

On the advice of Code Analysis in VS to call Dispose on an object (which I wasn’t previuosly) I ended up with a method containing this:

using (var favicon = new HtmlLink
                         {
                             Href = "~/templates/default/images/cc_favicon.ico"
                         })
{
    favicon.Attributes.Add("rel", "shortcut icon");
    Header.Controls.Add(favicon);
}

This confused me slightly, if I dispose this object after adding it to the Controls collection is that such a good idea?

How does this still work? Is it because the Controls.Add method disposes the object after use as opposed to holding on to it?

Answer 1

I would say that this code shouldn’t work but if you say it’s working then the only things I can think of are:

• Header.Controls.Add add a copy of the object so there is no problem disposing the original.
• The Dispose method does not clean anything that is used later.

Hope this helps.