Question

Our 3rd Party app has a custom View with the following:

FROM dbo.vwPositionAssetSubWeight 
INNER JOIN dbo.vwPositionAssetSubTotal 
    ON dbo.vwPositionAssetSubWeight.AssetID = dbo.vwPositionAssetSubTotal.AssetID 
FULL OUTER JOIN dbo.vwPositionAssetPendingTrades 
    ON dbo.vwPositionAssetSubWeight.AssetID = dbo.vwPositionAssetPendingTrades.AssetID
, dbo.vwPositionPortfoliosTotal

Note: There is no where clause.

Some of this mess makes sense, but I’m not familiar with how the last view is joined or maybe not joined. Is dbo.vwPositionPortfoliosTotal a cross join on everything? That is my guess. Also, dbo.vwPositionPortfoliosTotal returns one row.

What is the best way to rewrite this, so it makes sense to the next developer?

Oh, no aliases, 111 returned fields, no documentation, remarks, hints or even a trail of bread crumbs.

Answer 1

These two statements are equivalent.

SELECT *
FROM a, b

SELECT *
FROM a CROSS JOIN b

Examine your where clause… there might be joining criteria hiding in it that would cause you to choose inner/outer joins instead.