Question

Please pardon me for a n00bish question.

Please consider the following code:

public class SampleClass
{
    public string sampleString { get; set; }
    public int sampleInt { get; set; }
}


class Program
{
    SampleClass objSample;


    public void SampleMethod()
    {
        for (int i = 0; i < 10; i++)
        { objSample = new SampleClass();
            objSample.sampleInt = i;
            objSample.sampleString = "string" + i;

            ObjSampleHandler(objSample);
        }
    }

    private void ObjSampleHandler(SampleClass objSample)
    {
       //Some Code here
    }
}

In the given example code, each time the SampleMethod() is called, it would iterate for 10 times and allocate new memory space for the instance of SampleClass and would assign to objSample object.

I wonder,

• If this is a bad approach as a lot of
  memory space is being wasted with it?

• If that is the case, is there a
  better approach to reuse/optimize the
  allocated memory?

Or, Am I getting worried for no reason at all and getting into unneccesary micro optimisation mode ? 🙂

Edit: Also consider the situation when such a method is being used in a multi threaded enviornment. Would that change anything?

Answer 1

The technical term for what you are doing is premature optimization

You’re definitely doing well to think about the performance implications of things. But in this case, the .NET Garbage Collector will handle the memory fine. And .NET is very good at creating objects fast.

As long as your class’s constructor isn’t doing a lot of complex, time-consuming things, this won’t be a big problem.