Question

Possible Duplicate:
Android error – close() was never explicitly called on database

I have a problem in my android app.

I have a singleton implemented which has a method with the following code:

public Cursor getFooCursor(Context context)
{
    StorageDBOpenHelper helper = new StorageDBOpenHelper(context);
    SQLiteDatabase db = helper.getReadableDatabase();

    Cursor c = db.query("Foo", new String[] {"_id", "Titel"}, null, null, null, null, "Test DESC");

    return c;
}

when i use this, i sometimes get the error: SQLiteDatabase: close() was never explicitly called on database

how to avoid this? the problem is, i can not simply make a db.close() befor i return c, because then its empty.

Answer 1

The approach I use is to pass an instance of the db to a class that returns the cursor:

StorageDBOpenHelper helper = new StorageDBOpenHelper(context);
SQLiteDatabase db = helper.getReadableDatabase();

public Cursor getFooCursor(Context context, SQLiteDatabase db ) {
      Cursor c = db.query("Foo", new String[] {"_id", "Titel"}, null, null, null,
 null, "Test DESC");
      return c;
 }

db.close();