Question

Possible Duplicate:
How to compare strings

I want to Compare to registry string values and if they were the same an messagebox appears

Currently I’m using this functions , It returns the value correctly but whenever I want to compare them, The compare result is always wrong

char* GetRegistry(char* StringName)
{
DWORD dwType = REG_SZ;
HKEY hKey = 0;
char value[1024];
DWORD value_length = 1024;
const char* subkey = "SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\MCI\\Player";
RegOpenKey(HKEY_LOCAL_MACHINE,subkey,&hKey);
RegQueryValueEx(hKey, StringName, NULL, &dwType, (LPBYTE)&value, &value_length);
return  value;
}

I use this to compare them

if (GetRegistry("First") == GetRegistry("Second"))
{
MessageBox(NULL,":|",":|",1);
}

But the MessageBox appears how ever The values are different

Any help is appreciated.

Answer 1

By using std::string, comparison would behave as you expected. Also that would fix another bug that the function returns a pointer to a local buffer.

std::string GetRegistry(const char* StringName)
{
....
return std::string(value);
}