Question

Possible Duplicate:
Javascript outer scope variable access

I have a javascript module that looks something like below. The main issue I’m having is how to access variables in the “this” scope from the private someOtherFunc. Is there a way to access this.myvar in the private someOtherFunc

var mymodule = (function(){

    return {   
        MyObj : function() {

            this.myvar = 123;

            this.publicfunc = function() {
                someOtherFunc();
            };

            var someOtherFunc = function() {
                //this doesn't seem to work
                this.myvar = 456;
            };

        }
     }
}

The idea is that I want to be able to do something like

new mymodule.MyObj().publicfunc, but make the someOtherFunc private

Answer 1

Forget my previous answer. You can do this just by adding a private version of this.

var mymodule = (function() {
    return {   
        MyObj : function() {
            this.myvar = 123;
            var that = this;

            this.publicfunc = function() {
                someOtherFunc();
            };

            var someOtherFunc = function() {
                that.myvar = 456;
            };
            return this;
        }
    };
});

Bear in mind that, with your code, every time you call MyObj you get a new object.
So this would do what you want:

>var o = new mymodule().MyObj()
>o.myvar
123
>o.publicfunc()
>o.myvar
456

but not this

>var m = new mymodule()
>m.MyObj().myvar
123
>m.MyObj().publicfunc()
>m.MyObj().myvar
123

If that’s not what you want, consider doing something like this

var mymodule = (function() {
    var myObj = null;
    this.MyObj = function() {
        if(myObj != null)
            return myObj;
        myObj = {};
        myObj.myvar = 123;

        myObj.publicfunc = function() {
            someOtherFunc();
        };

        var someOtherFunc = function() {
            myObj.myvar = 456;
        };
        return myObj;
    };
});