Question

Possible Duplicate:
Passing only two variables between controller and view – best practice?

There is my action:

  def list
    @codes = Code.order("created_at")
    @languages = Language.order('name').collect {|l| [l.name, l.coderay]}
  end

There is my view(I removed some lines):

<% @codes.each do |code| %>
    <div class="code">
        <%= link_to code.title, :action => 'show', :id => code.id %>
        <% if  code.author %>
            @<%= code.author %>
        <% end  %>
    </div>
<% end %>
<%= render :partial => 'shared/error_messages', :locals => {:object => @code} %>
<%= form_for :code, :url => {:action => 'create' }, :html => {:multipart => true} do |f| %>
    <%= f.text_field :title %><br />
    <%= f.text_area :content %><br>
    <%= f.select(:language, @languages, {:selected => 'text'}) %>
    <%= f.text_field :author %><br>
    <%= f.submit "Submit code" %>
<% end %>

There are 3 variables in it: @codes(list of posts), @code(current post, used in another action) and @languages.

My IDE writes:

At most two instance variables should be shared between controller and
view
This inspection warns if there are more than two instance
variables shared between a controller and a view. A controller should
only manage one instance variable, plus a second one for the
current_user variable.

Usually I share more variables between Controller and View(in PHP), sometimes 10+.
How it’s done in Rails?

Answer 1

You can save an instance var by making languages a helper:

def languages
  Language.order('name').collect {|l| [l.name, l.coderay]}
end