Question

Possible Duplicate:
TextBox.Text Leaking Memory in WPF Application

I’ve got an application trailing a logfile. Every time the logfile updates (which is usually a series of updates in a row) the memory use balloons out of control.

I’ve tracked down the problem to this call:

    if (File.Exists(Path + "\\logfile.txt"))
                Data = File.ReadAllText(Path + "\\logfile.txt");

This is being called from within LoadAllData, here.

    private void FileChangeNotificationHandler(object source, FileSystemEventArgs e)
    {
        this.Dispatcher.BeginInvoke
          (new Action(delegate()
          {
              Logfile.GetPath();
              Logfile.LoadAllData();

              LogText.Clear();
              LogText.Text = Logfile.Data;
              if (CheckFollowTail.IsChecked == true) LogText.ScrollToEnd();
          }));
    }

Does anyone have insight on why this occurring? I assume it’s related to the delegate or the handler.

Answer 1

It’s probably just down to the amount and frequency with which you are loading log file data into memory.

GC takes time, so it you are repeating this in quick succession, then chances are you’ll have several files worth of data in memory until the next GC. This seems very inefficient. You should consider the use of a stream based reader, to avoid keeping all the data in memory. If you do use a stream reader, make sure you dispose of it afterwards to avoid introducing another leak.

The another thing to check it that your not subscribing to a static event somewhere and therefore preventing your object tree from being disposed. Is it a web app?