Possible Duplicate:
When is a Java method name too long?
I know this is probably is a question of personal opinion, but I want to know what’s standard practice and what would be frowned upon.
One of my profs in university always seems to make his variable and method names as short as possible (getAmt() instead of getAmount) for instance.
I have no objection to this, but personally, I prefer to have mine a little longer if it adds descriptiveness so the person reading it won’t have to check or refer to documentation.
For instance, we made a method that given a list of players, returns the player who scored the most goals. I made the method getPlayerWithMostGoals(), is this wrong? I toiled over choosing a way to make it shorter for awhile, but then I thought “why?”. It gets the point across clearly and Eclipse makes it easy to autocomplete it when I type.
I’m just wondering if the short variable names are a piece of the past due to needing everything to be as small as possible to be efficient. Is this still a requirement?
I prefer to have long variable/method names that describe what’s going on. In your case, I think getPlayerWithMostGoals() is appropriate. It bothers me when I see a short variable name like “amt” and I have to transpose that in my head (into “amount”).