Question

Possible Duplicate:
Which is preferred: Nullable<>.HasValue or Nullable<> == null?

I’m working in a codebase which uses both of the following forms for “safely” getting values out of Nullable types. For example, if foo is a Nullable (int?):

if (foo != null) {
    value = (int)foo;
}

if (foo.HasValue) {
    value = foo.Value;
}

I prefer the second form, but is there any particular context which might make the first (or the second, for that matter) certainly preferred over the other?

Answer 1

The first and second are exactly equivalent, and compile down to the same IL.

EDIT: They do indeed generate the same IL, like this:

  IL_000b:  ldloca.s   V_1
  IL_000d:  call       instance bool valuetype 
                           [mscorlib]System.Nullable`1<int32>::get_HasValue()
  IL_0012:  ldc.i4.0
  IL_0013:  ceq
  IL_0015:  stloc.2
  IL_0016:  ldloc.2
  IL_0017:  brtrue.s   IL_0023
  IL_0019:  nop
  IL_001a:  ldloca.s   V_1
  IL_001c:  call       instance !0 valuetype
                           [mscorlib]System.Nullable`1<int32>::get_Value()
  IL_0021:  stloc.0

This is guaranteed by section 7.10.9 of the C# 4 spec (or the equivalent in other versions).

Basically – use whichever form you and your team find more readable.

Anton highlighted the null-coalescing operator – while Anton’s code isn’t equivalent to yours, it’s an operator that you definitely should be familiar with, as it can really make for nice code.