Question

public class RootActivity extends Activity
{
    static LiLa superLayout;

    @Override
    public void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        main();
        setContentView(superLayout);
    }

    private void main()
    {
        // LiLa is a class which extends LinearLayout
        superLayout = new LiLa(this);

        //DownloadData is an AsyncTask
        DownloadData mDownloadData = new DownloadData(this);
        mDownloadData.execute();
    }
}

So the AsyncTask change some parts of the superLayout, for now in the AsyncTak, I do :

RootActivity.superLayout.tv.setText("hello");

Would it be better to change :

static LiLa superLayout;

to

LiLa superLayout;

and :

DownloadData mDownloadData = new DownloadData(this);

to

DownloadData mDownloadData = new DownloadData(this, superLayout);

So that it would be possible to do in the AsyncTask :

superLayout.tv.setText("hello");

So question is : is it better to access this kind of parameters (TextView tv for example) or a method to change this TextView through static way or via parameter ?

Thanks for reading me.

EDIT : btw in my code it is a bit more messy it could be more like

RootActivity.superLayout.class1.class2.tv.setText("hello");

Answer 1

It would be better to avoid using a static in this case, and if that means that you need to pass the value as a parameter, that’s fine too. (Statics are not O-O, and are generally a bad idea in an O-O design. They also present problems in unit testing.)

It is also generally a good idea to declare all instance variables and provide getter and/or setter methods if that is required.