Question

public static string UpperCaseStringSplitter(string stringToSplit)
{
    var stringBuilder = new StringBuilder();
    foreach (char c in stringToSplit)
    {
        if (Char.IsUpper(c) && stringToSplit.IndexOf(c) > 0)
            stringBuilder.Append(" " + c);
        else
            stringBuilder.Append(c);
    }
    return stringBuilder.ToString();
}

If I pass a string like this:

TestSrak

the output is the expected one : "Test Srak".

But when there are two same letters where one is lower case and the other is Uppercase next to each other, the split does not happen:

For example If the input is:

TestTruck

The output is also TestTruck . Can You please tell me where is the problem and how can I fix it. Thanks!

Answer 1

The problem is this

stringToSplit.IndexOf(c) > 0)

In "TestTruck" the first letter(index == 0) is also a T, therefore it will not enter the if.

Instead i would use a for-loop and check if the current char is the first, then you can skip the split:

for(int i=0; i < stringToSplit.Length; i++)
{
    if (i > 0 && Char.IsUpper(stringToSplit[i]))
        stringBuilder.Append(" ").Append(stringToSplit[i]);
    else
        stringBuilder.Append(stringToSplit[i]);
}