Question

Quick question to do with php functions, it may sound silly to some of you but I dont want to get in to bad habits. Is there anything wrong with doing the following?

function do_something($val)
{
  $a = 1;
  if ($val==$a)
  {
    return true;
  }
  return false;
}

Instead of;

function do_something($val)
{
  $a = 1;
  if ($val==$a)
  {
    return true;
  }
  else
  {
    return false;
  }
}

Sorry guys I think my example isn’t great. Basically the function could insert data into a database or send an email etc. With these functions I may only need to now whether it was successful or not by returning true or false. I wanted to know whether its suitable that I can use the shorter method instead of the if-else block.

I hope that makes it clearer.

Answer 1

No, that is perfectly fine, and in fact advised in multiple cases. 🙂