Question

Recently I receive a email, claiming that he can change my admin password by sql injection.
Here is my code. It is developed using Yii php framework. Can anyone see the flaws?

    public function actionLogin()
{

    $model=new LoginForm;

    // if it is ajax validation request
    if(isset($_POST['ajax']) && $_POST['ajax']==='login-form')
    {
        echo CActiveForm::validate($model);
        Yii::app()->end();
    }

    // collect user input data
    if(isset($_POST['LoginForm']))
    {
        $model->attributes=$_POST['LoginForm'];
        // validate user input and redirect to the previous page if valid
        if($model->validate() && $model->login())
            $this->redirect(Yii::app()->user->returnUrl);
    }
    // display the login form
    $this->render('login',array('model'=>$model));
}

Answer 1

Every where you are creating sql queries, you must bind all external variable with sql variables, It will remove sql injection possibility.