Question

Say I have a variable called “true” in a function called “test.” Then I have another function in a whole different script tag and I want to change “true” using my new function. How can I do this? Thanks.

<script type="text/javascript">
var hello="no";
if(hello=="yes"){ 
  window.onbeforeunload = confirmExit;
  function confirmExit()
  {
    return "Message";
  }
}
</script>

<script type="text/javascript">
function show(id) {
     $('#' + id).show();
     var hello="yes";


}
</script>

It doesnt seem to be working…

Answer 1

In your function, don’t use the var keyword. Doing so declares a different variable hello in scope of the function.

// Earlier, you defined the variable at a higher scope here:
var hello="no";
// The function has *not* been called yet, so hello will never equal "yes" when this initially runs.
if(hello=="yes"){ 
  window.onbeforeunload = confirmExit;
  function confirmExit()
  {
    return "Message";
  }
}

function show(id) {
  $('#' + id).show();
  // No var here!
  // the variable was defined at a higher (window) scope already with the var keyword.
  hello="yes";
}

Update:

Your logic is faulty when calling the onbeforeunload. You are never binding the event unless hello == "yes", which it never does when that runs. Instead, check the variable contents in the confirmExit() function:

window.onbeforeunload = confirmExit;
function confirmExit()
{
  if (hello == "yes") {
    return "Message";
  }
}