Question

Say that I have one constructor that takes an input and another that uses a default value. Both constructors then proceed to process this data in exactly the same way. (Example below.) What are my options to avoid code duplication in this case?

(I’ve read the post how to reduce the code of constructor overloading, where the top answer suggests using the keyword “this”. In my case, I guess I would need to use “this” to call the first constructor from the second one after the input has been stored. This however results in a compilation error: “call to this must be first statement in constructor”.)

Example code:

public class A {
  public A(String a) {
    //process a
  }
  public A() {
    String a = "defaultString";
    //process a
  }
}

EDIT: I’m taking a lot of fire for using an input dialog call in a class constructor (which I’m aware isn’t exactly good practice). So I’ve changed the code example to direct the discussion away from this :).

Answer 1

One way is to have an init method:

public class A {
    public A(String a) {
        init(a);
    }
    public A() {
        String a = "defaultString";
        init(a);
    }
    private void init(String a) {
        //process a
    }
}