Sign Up to our social questions and Answers Engine to ask questions, answer people’s questions, and connect with other people.
Login to our social questions & Answers Engine to ask questions answer people’s questions & connect with other people.
Lost your password? Please enter your email address. You will receive a link and will create a new password via email.
Please briefly explain why you feel this question should be reported.
Please briefly explain why you feel this answer should be reported.
Please briefly explain why you feel this user should be reported.
See question in the title! Would you ‘inject’ or rather ‘new’ a Comparator? Would you new it if the order of elements is set in the specification and is likely not to change?
The question “should I inject this dependency?” is really “should the referring object know about the nature of this dependency?”. Er, only negated.
If your class is a
FastestPonyFinder, and it needs to sort aList<Pony>by speed, then i would say it should know about the comparator. The comparator needs to compare by speed, sorting the fastest to the head of the list; no other comparator is suitable for the job. The object should create the comparator, just like it created theList.If your class is a
BestPonyFinder, then it probably should have the comparator injected, because the definition of what constitutes ‘best’ is separable from the definition of how to find the pony which meets it. This is going to make your code easier to test and easier to change in the future.