Question

Simple Bash +1 please

Hey there. I know I’m missing something simple in this script. But what is it? an exit? fi?
When I use Name -online i get the echo “Bool Changed offline2” from the very last section. Online code shouldnt clash with Offline. Help, I’ve been at this for hours.

if [ "$1" == "-online" ]; then
        if [ "$Check" == "com.company.package1" ]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package1 &> /dev/null
            echo "Bool Changed online1"
            exit
        fi
    else
        if [ "$Check" == "com.company.package2" ]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package2 &> /dev/null  ////EDITED TO com.company.package2
            echo "Bool Changed online2"
            exit        
        fi
    fi


if [ "$1" == "-offline" ]; then
        if [ "$Check" == "com.company.package1" ]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package1 &> /dev/null
            echo "Bool Changed offline1"
            exit
        fi
    else
        if [ "$Check" == "com.company.package2" ]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package2 &> /dev/null  //EDITED TO com.company.package2
            echo "Bool Changed offline2"
            exit        
        fi
    fi

Answer 1

Assuming that $Check is set to “com.company.package2” (which, unfortunately you don’t show), this is what your script is doing:

• The first if is true because the command argument is “-online”.
• The second if is false (“package2” != “package1”)
• The first else is skipped since the first if was true
• The “-offline” if is false, so its else path is taken
• The final if is true (“package2” != “package2”) so the message is echoed

else if is not the same as elif

Because you close the inner if statements with fi, the else is evaluated for the outer if statements.

You probably want:

#!/bin/bash

Check=com.company.package2

if [[ $1 == "-online" ]]; then
        if [[ $Check == "com.company.package1" ]]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package1 &> /dev/null
            echo "Bool Changed online1"
            exit
        elif [[ $Check == "com.company.package2" ]]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package2 &> /dev/null  ////EDITED TO com.company.package2
            echo "Bool Changed online2"
            exit
        fi
elif [[ $1 == "-offline" ]]; then
        if [[ $Check == "com.company.package1" ]]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package1 &> /dev/null
            echo "Bool Changed offline1"
            exit
        elif [[ $Check == "com.company.package2" ]]; then
            plutil -key settingsOfflineMode -value 0 -type bool /the/dir/ect/ory/com.company.package2 &> /dev/null  //EDITED TO com.company.package2
            echo "Bool Changed offline2"
            exit
        fi
fi