Question

Since i don’t have the ModuleID, I’d like to get from the Modules table first using the ModuleName.

ALTER PROCEDURE dbo.spEditTask
@ID                     int,
@ModuleName             varchar(50), 
@Task                   varchar(50), 
@ListOfDevelopers       varchar(50),
@StartDate              date, 
@PlannedEndDate         date, 
@EstimatedEndDate       date, 
@Status                 varchar(50),
@Comments               varchar(500),
@LastAction             varchar(50),
@Started                 bit
AS
BEGIN 

  DECLARE @ModuleID int; 
  SET @ModuleID = 
  (SELECT ModuleID 
  FROM Modules
  WHERE ModuleName = @ModuleName); 
  GO

  UPDATE DTasks
SET ModuleID = @ModuleID, 
    Task = @Task, 
    ListOfDevelopers = @ListOfDevelopers, 
    StartDate = @StartDate, 
    PlannedEndDate = @PlannedEndDate, 
    EstimatedEndDate = @EstimatedEndDate, 
    Status = @Status, 
    Comments = @Comments, 
    LastAction = @LastAction,
    Started  = @Started,
    LastUpdated = GETDATE() 
WHERE ID  = @ID
GO
END

Thanks for helping

Answer 1

You need to wrap your lines in begin and end

ALTER PROCEDURE dbo.spEditTask 
@ID                     int, 
@ModuleName             int, 
@Task           varchar(50) 
as 
begin     
    DECLARE @ModuleID int;  

    SELECT @ModuleID = ModuleID  
    FROM Modules 
    WHERE ModuleName = @ModuleName  

    UPDATE DTasks 
    SET   ModuleID = @ModuleID,  
      Task = @Task,  
    WHERE ID   = @ID 
end

although you could use just a single line

UPDATE DTasks
SET
   ModuleID = Modules.ModuleID,
   Task = @task
FROM DTasks cross join Modules
WHERE DTasks.ID = @ID
AND Modules.ModuleName = @ModuleName