Question

Site:

http://tinyurl.com/ah9hkgz

Issue: I’m trying to write simple javascript function to calculate subtotals and totals of order for customer. I got arrows to increment/decrement values for each product.

Tried to write function cash(qty); that is called onclick together with other “inline javascript” codes. On site, only first product’s UP arrow is calling cash function.

When function cash is called, the document.getelementbyid('szett_subtotal').Value=price; doesn’t work.

cash function:

function cash(qty)
{
   var price = 0;
   price = 12990 + ((qty.value-1)*9990); 
   document.getelementbyid('szett_subtotal').Value=price;
)

Thanks for your help. I hope.

Clarification

Down button does not contain this cash function call because I am focusing on up button for test purpose.

Answer 1

Your function declaration of cash causes a parse error:

function cash(qty)
{
   var price = 0;
   price = 12990 + ((qty.value-1)*9990); 
   document.getElementById('szett_subtotal').value=price; 
)
^
Uncaught SyntaxError: Unexpected token )

Function body should end with a curly end brace }.

Also, don’t use inline JavaScript code, it’s error prone and adding behaviour from outside the HTML is preferred, such as .addEventListener().

The easiest to do is create a click handler function and call that from inline:

function inc_quantity(v)
{
  var qty_el = document.getElementById(v);
  var qty = qty_el.value;
  if( !isNaN( qty )) qty_el.value++;
  cash(qty_el);
}

  ... onclick="inc_quantity('quantity_szett')"