Question

So far I have my app taking a picture creating a new folder on the SD Card and saving the pictuers into the new folder.

I’m trying to get it so once the picture has been took it will display in a new Activity with two buttons that say “Use” or “Retake”. So far the image saving is working perfectly fine but once the image has been took and it tries to open the new Activity it just stays on the camera Activity and shows the image which I cant use as it has a surfaceView onit.

In my LogCat I get the error “Oh, no reference” which is set to show if it can’t find the picture, which is why im thinking it may be because I am not calling the picture from the correct place in my Punch.java.

So basiclly I am trying to once an image has been took the app to open a New Activity “Punch.java” and display the image that has just been took.

UPDATE Thanks to Lumis (code below has been updated)

Changed

intent.putExtra("filepath",uriSavedImage);

to

intent.putExtra("filepath",uriSavedImage.toString());

Which now opens the new Activity but still cannot see the image.

UPDATE 2 Punch.java

I have updated my Punch.java as with the new code if i change (myRef) to "/sdcard/Punch/image_0.jpg" I can see that image but I need it to referance to the image that was just taken with the camera which is something to do with this line I think intent.putExtra("filepath",uriSavedImage.toString());

Update 3

Nearly working perfectly now using intent.putExtra("filepath",Uri.parse(output.getAbsolutePath()).toString()); but for some reason it is still putting mnt/sdcard at the start it just needs to be sdcard/

Ok now working fine /mnt/sdcard is when the sdcard was mounted to the computer while i took the picture.

In my Camera Activity I have

PictureCallback myPictureCallback_JPG = new PictureCallback(){

    public void onPictureTaken(byte[] arg0, Camera arg1) {
        // TODO Auto-generated method stub
        /*Bitmap bitmapPicture 
            = BitmapFactory.decodeByteArray(arg0, 0, arg0.length);  */
        int imageNum = 0;
        Intent imageIntent = new Intent(android.provider.MediaStore.ACTION_IMAGE_CAPTURE);
        File imagesFolder = new File(Environment.getExternalStorageDirectory(), "Punch");
        imagesFolder.mkdirs(); // <----
        String fileName = "image_" + String.valueOf(imageNum) + ".jpg";
        File output = new File(imagesFolder, fileName);
        while (output.exists()){
            imageNum++;
            fileName = "image_" + String.valueOf(imageNum) + ".jpg";
            output = new File(imagesFolder, fileName);
        }

        Uri uriSavedImage = Uri.fromFile(output);
        imageIntent.putExtra(MediaStore.EXTRA_OUTPUT, uriSavedImage);


        OutputStream imageFileOS;
        try {
            imageFileOS = getContentResolver().openOutputStream(uriSavedImage);
            imageFileOS.write(arg0);
            imageFileOS.flush();
            imageFileOS.close();

            Toast.makeText(AndroidCamera.this, 
                    "Image saved", 
                    Toast.LENGTH_LONG).show();

        } catch (FileNotFoundException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        } catch (IOException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }

        Intent intent = new Intent(getBaseContext(), Punch.class);
        intent.putExtra("filepath",uriSavedImage.toString());
        //just using a request code of zero
        int request=0;
        startActivityForResult(intent,request); 
    }};

And my Punch.java which is the next Activity is:

    @Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.punch);

    String myRef = this.getIntent().getStringExtra("filepath");

    File imgFile = new  File(myRef);
    if(imgFile.exists()){

        Bitmap myBitmap = BitmapFactory.decodeFile(imgFile.getAbsolutePath());

        ImageView myImage = (ImageView) findViewById(R.id.imagepunch);
        myImage.setImageBitmap(myBitmap);

    }

}

}

Answer 1

I think it is the file path issue. You submitted your file path as URI but you are reading it in the viewer activity as a string.

Perhaps you neet to change this line into:

intent.putExtra("filepath",uriSavedImage.toString());

Or

intent.putExtra("filepath",Uri.parse(output.getAbsolutePath()).toString()); 

Different version of android may not work the same when it comes to file path, so you need to experiment using Uri.parse(fileStr) or String…