Question

So I currently have a 2d list of objects that define the map of a game where each object represents a tile on that map. As I was repurposing the code for something else, I wondered if it would make more sense to use a dictionary to store the map data or to continue using a list. With a list, the indices represent the x and y of the map, whereas in a dictionary, a (x,y) tuple would be the keys for the dictionary.

The reason I ask is because the map changing is a rare event, so the data is fairly static, and as far as i know, the fairly constant lookups will be faster in dictionaries. It should also simplify looping through the map to draw it. Mostly I think using dictionaries will simplify accessing the data, though I’m not sure that will be the case in all cases.

Are these benefits worth the additional memory that I assume the dictionary will take up? or am I even right about the benefits being benefits?

EDIT
I know that the current method works, its was moreso to whether or not it would make sense to switch in order to have cleaner looking code and to find any potential drawbacks.
Stuff like looping through the array would go from something like

for i in range(size[0]):
    for e in range(size[1]):
        thing.blit(....using i and e)

to

for i, e in dict.items():
    i.blit(....using i and e)

or looking up a dict item would be

def get(x, y):
    if (x in range(size[0])) and (y in range(size[1])):
        return self.map[x][y].tile

to

def get(item):
    return self.dict.get(item)

its not much, but its somewhat cleaner, and if its not any slower and there are no other drawbacks i see no reason not to.

Answer 1

I would be wary of premature optimization.

Does your current approach have unacceptable performance? Does the data structure you’re using make it harder to reason about or write your code?

If there isn’t a specific problem you need to solve that can’t be addressed with your current architecture, I would be wary about changing it.