Home/ Questions/Q 8717437
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-06-13T06:18:21+00:00

So i have done this simple task but i don’t see why this is

  • 0

So i have done this simple task but i don’t see why this is not working? Can same one see it and tell me? I see that the problem is that button does not call out the function but why ? 

<html>
<head>
    <title>Task count</title>
    <script>
        var over21 = 6.19;
        var under21 = 5.19;

        // Getting data from a user connecting variables with textboxes by ID
        var age = document.getElementById('age');
        var hours = document.getElementById('hours');

        // function wich does all of the calculation
        function magic(){    
            //cheking if he is under or over 21 
            if(age < 21){
                alert("You will make " + (age*under21));
            }else{
                alert("You will make " + (age*over21));                            
            };
        };

        // function that does everything and is connected to the button
        function myFunction(){
            // Validation checking that entered number is not more than 150 
            // And also if age is correct
            if((hours < 150 && hours > 0) && (age < 150 && age > 12)){
                magic();
            }else{
                alert("Wrong!");
            };
        };
  </script>
</head>
<body>
    <label>Enter your age.(12-150)</label>
    <input type="text" class="textBox" id="age"><br>
    <label>Enter how long will you work.(1-150)</label>
    <input type="text" class="textBox" id="hours"><br>
    <button onclick="myFunction()" >How much will i make ?</button>
</body>
</html>​
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    I would suggest not using so many global variables.

    Move:

    var age = document.getElementById('age');
var hours = document.getElementById('hours');

    into myFunction().

    You’ll then need to make those two:

    var age = parseInt(document.getElementById('age').value);
var hours = parseInt(document.getElementById('hours').value);

    We use parseInt to take the value as a string and turn it into an integer value.

    Since age and hours are now defined in myFunction, you’ll need to pass age to magic()

        var over21 = 6.19;
    var under21 = 5.19;

    // function wich does all of the calculation
    function magic(age){

      //cheking if he is under or over 21 
       if(age < 21){
             alert("You will make " + (age*under21));
       }else{
             alert("You will make " + (age*over21));                            
       };
    };
    // function that does everything and is connected to the button
    function myFunction(){

    var age = parseInt(document.getElementById('age').value);
    var hours = parseInt(document.getElementById('hours').value);
     // Validation checking that entered number is not more than 150 // And also if age is correct
     console.log(age + " : " + hours)   
        if((hours < 150 && hours > 0) && (age < 150 && age > 12)){
           magic(age);
        }else{
            alert("Wrong!");
        };
    };

    Also, if you want (1-150), you’ll need to modify this if statement: 

    if((hours < 150 && hours > 0) && (age < 150 && age > 12)){ ... }

    to:

    if((hours <= 150 && hours > 0) && (age <= 150 && age > 12)){ ... }

    Lastly, I believe the math may be incorrect in the magic() function:

    function magic(age, hours){

  //cheking if he is under or over 21 
   if(age < 21){
         alert("You will make " + (hours*under21));
   }else{
         alert("You will make " + (hours*over21));                            
   };
};

    I believe you wanted hours*under21 and hours*over21. Note that hours is now also being passed in as a parameter.

    EXAMPLE

    • 0