Question

so i start a ASIFormDataRequest on my [viewDidLoad] in a UIViewController.

ASIFormDataRequest *detailRequest = [ASIFormDataRequest requestWithURL:url];
detailRequest.delegate = self;
[detailRequest startAsynchronous];

If my UIViewController gets released before my Request finishes, my app crashes.

If i add my ASIFormDataRequest as an instance variable for example

@property(nonatomic, retain) ASIFormDataRequest *detailRequest;

and nil the delegate on dealloc

-(void)dealloc {
    if(self.detailRequest != nil) { self.detailRequest.delegate = nil; }
    self.detailRequest = nil;

    [super dealloc];
}

the app no longer crashes.

but i don’t think it’s necessary to create a instance variable just for this, especially if i have multiple requests.

is there a better way to do this?

Answer 1

I usually create an array and store all active requests in the array. When the request is completed I remove the request, and when the controller calls dealloc I cancel all of the requests and nil the delegate.