Question

So my last attempt at asking this question was vague. So I’ll try this again.

I have created a system that makes use of a bookmarklet for populating. Now, in all major browsers (excl. IE8), you can drag/add the bookmarklet to the favourites with no problem. Even when trying to add it manually, it doesn’t seem to work. Is this a code issue?

Here is the bookmarklet code:

javascript:var metatags, my_arr=document.getElementsByTagName('META'), sel=document.selection.createRange().text,d=document, f, counter;
for(counter=0;counter<my_arr.length;counter++)
{
    if(my_arr[counter].name.toLowerCase()=='description')
    {
        metatags=my_arr[counter].content;
    }
}
f='http://xxxxxxxxxxx.co.za/common/UserControls/ShareThis/ShareThis.aspx', l=d.location, e=encodeURIComponent,u=f+'?u='+e(l.href)+'&t='+e(d.title)+'&s='+e(sel.length<1?metatags?metatags:'':sel)+'&v=4';

a=function()
{
    if(!window.open(u, 't', 'toolbar=0, resizable=1, scrollbars=1, status=1, width=720, height=570'))
        l.href=u;
};
a();

Answer 1

Right click on the bookmarklet, and choose “Add to Favorites”. Then click the new bookmark. If it doesn’t work, it is a code issue.

Also, generally, copy/paste into IE8 url bar should work as well.

I tested your bookmarklet and it worked fine. Below is what I used and tested and it worked. I tested by copy/paste into the URL bar.

javascript:var metatags,my_arr=document.getElementsByTagName('META'),sel=document.selection.createRange().text,d=document,f,counter;for(counter=0;counter<my_arr.length;counter++){if(my_arr[counter].name.toLowerCase()=='description'){metatags=my_arr[counter].content}}f='http://xxxxxxxxxxx.co.za/common/UserControls/ShareThis/ShareThis.aspx',l=d.location,e=encodeURIComponent,u=f+'?u='+e(l.href)+'&t='+e(d.title)+'&s='+e(sel.length<1?metatags?metatags:'':sel)+'&v=4';a=function(){if(!window.open(u,'t','toolbar=0, resizable=1, scrollbars=1, status=1, width=720, height=570'))l.href=u};a();

Sometimes bookmarklet problems are related to conversion of the readable code into bookmarklet format. I created above using http://javascriptcompressor.com/