Question

SOLVED: Read the comments below @Eray.

I have a PHP function to look through text and convert text emoticons to images. :), :(, :|, etc. I also have a function that looks through text and replaces BBCode with HTML. I execute these on a string from a database. Both of these use the global variable $newtext.

emoticon($row['words']);
bb($row['words']);
echo "<b>" . $row['username'] . "</b> - " . $row['time'];
echo "<p>" . $newtext . "</p>";
echo "";

The odd thing about this, is that now (I can’t remember what I did) the emoticon function doesn’t work, but the bb function does. By doesn’t work, I mean doesn’t replace anything. Text remains text. This had worked before. Also, every few times, $newtext comes before the username. Here are my functions…

function emoticon($text)
{
global $newtext;
$newtext=str_replace(":)", "<img src='emoticons/smile.gif'>", $text);
$newtext=str_replace(":(", "<img src='emoticons/sad.gif'>", $newtext);
$newtext=str_replace(":D", "<img src='emoticons/biggrin.gif'>", $newtext);
$newtext=str_replace(":p", "<img src='emoticons/tongue.gif'>", $newtext);
$newtext=str_replace(":P", "<img src='emoticons/tongue.gif'>", $newtext);
$newtext=str_replace(":|", "<img src='emoticons/neutral.gif'>", $newtext);
$newtext=str_replace("8)", "<img src='emoticons/cool.gif'>", $newtext);
$newtext=str_replace("8D", "<img src='emoticons/cool.gif'>", $newtext);
$newtext=str_replace(":o", "<img src='emoticons/surprised.gif'>", $newtext);
$newtext=str_replace(":O", "<img src='emoticons/surprised.gif'>", $newtext);
$newtext=str_replace(";)", "<img src='emoticons/wink.gif'>", $newtext);
$newtext=str_replace("^<**>^", "<img src='emoticons/crab.gif'>", $newtext);
}

function bb($text) 
{
global $newtext;
$array=array(

"[b]" => "<b>",
"[/b]" => "</b>",

"[i]" => "<i>",
"[/i]" => "</i>",

"[u]" => "<u>",
"[/u]" => "</u>",

"[big]" => "<h1>",
"[/big]" => "</h1>",

);
$newtext = str_ireplace(array_keys($array), array_values($array), $text);
}

Could you explain or help me? Also, is there a better way than using global variables? I know they can be a bit “dangerous.”

Answer 1

function emoticon($text)
{
$smiley = array(
    ':)',
    ':(',
);

$replace = array(
    "<img src='emoticons/smile.gif'>",
    "<img src='emoticons/sad.gif'>",
);

     return str_replace($smiley, $replace, $text);
}