Question

Sometimes, due to faulty data collected, a line generated by the following method ends up looking like this when saved: “,-1,0” or something similar, with no name, an ID of -1 and a level of 115 or something else. (The lines are formatted like this (excluding quotes): “name,id,level” (e.g: “Honour guard,5514,115”)

What i need to do is to remove all strings in monstersToAdd that contains -1.
I’ve tried this, but with no success:

private void combineInfo() {
    for(int i = 0; i < monsterList.size(); i++){
        monstersToAdd.add("" + names[i] + "," + IDs[i] + "," + levels[i]);
    }
    monstersToAdd.remove(monstersToAdd.contains("-1"));
}

with the line monstersToAdd.remove(monstersToAdd.contains("-1")); I was trying to remove all strings in monstersToAdd that contains “-1”. This however does not work, probably for good reasons, which I unfortunately don’t know of yet.

I would really appreciate any input :).

Answer 1

Its easier if you dont even add them, than adding and removing them so check the sanity of ID names and levels before adding them

private void combineInfo() {
for(int i = 0; i < monsterList.size(); i++){
    //add only if name is non empty, ID is not negative and level is below 100
    if(!(names[i].isEmpty() || IDs[i]<0 || levels[i]>100))
    monstersToAdd.add("" + names[i] + "," + IDs[i] + "," + levels[i]);
}