Question

Sometimes when I see my logging code I wonder if I am doing it right. There might be no definitive answer to that, but I have the following concerns:

Library Classes

I have several library classes which might log some INFO messages. Fatal Errors are reported as exceptions. Currently I have a static logger instance in my classes with the class name as the logging name. (Log4j’s: Logger.getLogger(MyClass.class))

Is this the right way? Maybe the user of this library class doesn’t want any messages from my implementation or wants to redirect them to an application specific log. Should I allow the user to set a logger from the “outside world”? How do you handle such cases?

General logs

In some applications my classes might want to write a log message to a specific log not identified by the class’ name. (I.e.: HTTP Request log) What is the best way to do such a thing? A lookup service comes to mind…

Answer 1

Your conventions are pretty standard and quite fine (imho).

The one thing to watch is memory fragmentation from excessive unnedded debug calls so, with Log4J (and most other Java logging frameworks), you end up with something like this:

if (log.isDebugEnabled()) {
  log.debug("...");
}

because constructing that log message (that you probably aren’t using) could be expensive, especially if done thousands or millions of times.

Your INFO level logging shouldn’t be too “chatty” (and from what you say, it sounds like it isn’t). INFO messages should be generally meaningful and significant, like the application being started and stopped. Things that you might want to know if you encounter a problem. Debug/fine level logging is more used for when you actually have a problem you’re trying to diagnose. Debug/fine logging is typically only turned on when needed. Info is typically on all the time.

If someone doesn’t want specific INFO messages from your classes, they are of course free to change your log4j configuration to not get them. Log4j is beautifully straightforward in this department (as opposed to Java 1.4 logging).

As for your HTTP thing, I’ve generally not found that to be an issue with Java logging because typically a single class is responsible for what you’re interested in so you only need to put it in one place. In the (rare in my experience) when you want common log messages across seemingly unrelated classes, just put in some token that can easily be grepped for.