Question

string Foo(string letter)
 {


      for (int j = 0; j < (int)alphabet.length(); j++)
     {

            if (letter[0] == (alphabet[j]));
                 return "SUCCESS";
      }

      return "FAILURE";


 }

alphabet = "Test";

cout << Foo("f") << endl;

This prints SUCCESS even thought it shouldn’t. What’s wrong with my comparison operator??

Answer 1

if (letter[0] == (alphabet[j])); // Note the semicolon at the end

You have an empty if immediately followed by return "SUCCESS";

Remove that semicolon:

if (letter[0] == alphabet[j])
    return "SUCCESS";