Question

string Newfilename;
string Defaultfilename;

        protected void btnup_Click(object sender, EventArgs e)
    {
        if (ASPxUploadControl1.HasFile)
        {
            string fileExt =
                Path.GetExtension(ASPxUploadControl1.FileName);


            if (fileExt == ".xls" || fileExt == ".xlsx")

                try
                {
                    string extension = Path.GetExtension(ASPxUploadControl1.FileName);
                    string id = Guid.NewGuid().ToString();
                    string fileLocation = string.Format("{0}/{1}{2}", Server.MapPath("upload/"), id, extension);
                    ASPxUploadControl1.SaveAs( fileLocation );
                    StatusLabel.Text = "Upload status: File uploaded!";

                    Newfilename = fileLocation;
                    Defaultfilename = Path.GetFileName(ASPxUploadControl1.FileName);

                }
                catch (Exception ex)
                {
                    StatusLabel.Text = "Upload status: The file could not be uploaded. The following error occured: " + ex.Message;
                }
            else
            {
                StatusLabel.Text = "Please choose excel file";
            }

        }
    }

I am trying to assign values to Newfilename and Defaultfilename (inside “try”, after naming uploaded file), but they stay empty.

Where I’m wrong?

Answer 1

Refactor your code and think about the process that you want .. then Debug the Code.. Test it.. and if you have an Issue then edit your post.. that’s what I suggest..
If statements should be wrapped with in a code block “{ }” same way that you have Try {} a good rule of thumb for even readability would be to wrap everthing around {} if you have If Else otherwise it makes if hard to read as well as lend assistance.

inside your code where you are declaring the following, make them variables within the method itself

• string fileExt = string.Empty;
• string extension = string.Empty;
• string id = string.Empty;
• string fileLocation = string.Empty;

so your method would look like this

protected void btnup_Click(object sender, EventArgs e)
{ 

    string fileExt  = string.Empty; 
    string extension = string.Empty;
    string id = string.Empty;
    string fileLocation = string.Empty;

    if (ASPxUploadControl1.HasFile)
    {              
         fileExt = Path.GetExtension(ASPxUploadControl1.FileName);
         if (fileExt == ".xls" || fileExt == ".xlsx")
         {
           try
           {
             extension = Path.GetExtension(ASPxUploadControl1.FileName);
             id = Guid.NewGuid().ToString();
             fileLocation = string.Format("{0}/{1}{2}", Server.MapPath("upload/"), id, extension);
             ASPxUploadControl1.SaveAs( fileLocation );
             StatusLabel.Text = "Upload status: File uploaded!";
             Newfilename = fileLocation;
             Defaultfilename = Path.GetFileName(ASPxUploadControl1.FileName);
            }                  
            catch (Exception ex)
            {
              StatusLabel.Text = "Upload status: The file could not be uploaded. The following error occured: " + ex.Message;
            }
         }
         else
        {
          StatusLabel.Text = "Please choose excel file";
        }
    }
}