Question

string to build up using keyvaluepair is like this: “name1=v1&name2=v2&name3=v3”

what i am doing:

var sb = new StringBuilder();

foreach (var name in nameValues)
{
            sb.AppendFormat("{0}={1}&", name.Key, name.Value);
 } 

//remove last '&' sign, this is what i think is ugly
sb.ToString().Remove(lastIndex);

any elegant way to avoid the last removal statement of ‘&’ sign?

Answer 1

var joined =
    String.Join("&", nameValues.Select(n => n.Key + "=" + n.Value).ToArray());

Given that we’re not concatenating to one big string (we’re producing many small strings) concatenation carries no performace penalties in this case. And in .NET strings are length prefixed anyway so the whole concatenation performance issue is less relevant than in C. String.Join() is very fast as well, faster than StringBuilder.

TLDR: Use String.Join()