Question

Surely there is a better way to do this?

results = [] if not queryset is None:     for obj in queryset:         results.append((getattr(obj,field.attname),obj.pk)) 

The problem is that sometimes queryset is None which causes an exception when I try to iterate over it. In this case, I just want result to be set to an empty list. This code is from a Django view, but I don’t think that matters–this seems like a more general Python question.

EDIT: I turns out that it was my code that was turning an empty queryset into a ‘None’ instead of returning an empty list. Being able to assume that queryset is always iteratable simplifies the code by allowing the ‘if’ statement to be removed. The answers below maybe useful to others who have the same problem, but cannot modify their code to guarantee that queryset is not ‘None’.

Answer 1

results = [(getattr(obj, field.attname), obj.pk) for obj in queryset or []]